-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds back retry_attempts to botocore #275
Merged
codeboten
merged 6 commits into
open-telemetry:master
from
thomasdesr:thomas/botocore-retry_attempts
Jan 6, 2021
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
51acc50
Add back retry_attempts to botocore
thomasdesr b11c016
Add retry_attempts into tests
thomasdesr ebe9afa
fixup! Add back retry_attempts to botocore
thomasdesr 8c74b6a
fixup! Add retry_attempts into tests
thomasdesr 880f643
Changelog :D
thomasdesr a1dd2e4
Merge branch 'master' into thomas/botocore-retry_attempts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
aws.retry_attempts
the right choice? The original code seems to just have retry_attempts.That makes sense to me, as retry attempts, albeit behavior in AWS's boto, is not really in aws-specific construct.
retry attempts actually seems quite generic, it probably should be a semantic convention in the spec.