datadog: do not add None tracestate value. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datadog exporter sometimes attempts to add a "None" value, if the datadog origin header doesn't exist. This does not cause runtime errors in the most recent opentelemetry release (tracestate protects against an invalid value), but does cause warnings: WARNING opentelemetry.trace.span:span.py:230 Invalid key/value pair (dd_origin, None) found.
toumorokoshi
requested review from
codeboten and
ocelotl
and removed request for
a team
ocelotl
approved these changes
Mar 10, 2021
codeboten
approved these changes
Mar 11, 2021
|
Shouldn't there have been a test included in this like I had in #272 ? |
The fix is a little different here, and really just removes a log warning. It felt excessive to test whether log warnings occur or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The datadog exporter sometimes attempts to add a "None" value to the TraceState, if the
datadog origin header doesn't exist.
This does not cause runtime errors in the most recent opentelemetry
release (tracestate protects against an invalid value), but does cause warnings:
WARNING opentelemetry.trace.span:span.py:230 Invalid key/value pair (dd_origin, None) found.
Fixes #262 (comment)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The existing tests suffice to verify my change didn't affect behavior, aside from the warning.
I was thinking of adding a log.capture test, but thought it would be overkill.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.