Reimplement the keys method in WSGI CarrierGetter #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinzaremba
requested review from
codeboten and
hectorhdzg
and removed request for
a team
owais
reviewed
Mar 25, 2021
| key[_CARRIER_KEY_PREFIX_LEN:].lower().replace("_", "-") | ||
| for key in carrier | ||
| if key.startswith(_CARRIER_KEY_PREFIX) | ||
| ] |
There was a problem hiding this comment.
Out of curiosity, did this prevent or limit propagation in some way when it was implemented as an empty list?
There was a problem hiding this comment.
It prevents any use case when information to be extracted is not known beforehand (for example HTTP headers starting with a particular prefix, but with unknown exact names). The great example is OT Trace Propagator, where the current implementation (empty list) renders injecting baggage unusable:
On the other hand when carrier would be manipulated directly, it would shift a specific implementation of keys translation (from uppercase, environ-like WSGI format) to every consumer.
There was a problem hiding this comment.
The great example is OT Trace Propagator, where the current implementation (empty list) renders injecting baggage unusable:
Thanks. This is what I was interested in.
owais
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements keys method in WSGI CarrierGetter (previously a static, empty list was returned)
Fixes #376
Type of change
How Has This Been Tested?
See the unit test added in this PR.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.