Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider propagator folder packages when building #387

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Consider propagator folder packages when building #387

merged 4 commits into from
Mar 31, 2021

Conversation

marcinzaremba
Copy link
Contributor

@marcinzaremba marcinzaremba commented Mar 30, 2021 •
edited

Description

Fixes #386

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Run ./scripts/build.sh
  2. Observe opentelemetry-propagator-ot-trace-0.19b0.tar.gz present in the dist/ folder

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@marcinzaremba marcinzaremba marked this pull request as ready for review March 30, 2021 08:02
@marcinzaremba marcinzaremba requested a review from a team as a code owner March 30, 2021 08:02
@marcinzaremba marcinzaremba requested review from owais and lzchen and removed request for a team March 30, 2021 08:02
@owais owais requested review from codeboten and removed request for owais March 30, 2021 10:45
@owais
Copy link
Contributor

owais commented Mar 30, 2021

Assigning @codeboten as a more appropriate reviewer for this.

@lzchen lzchen merged commit a946d5c into open-telemetry:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@lzchen lzchen lzchen approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentelemetry-propagator-ot-trace not released as a part of the release process
4 participants
@marcinzaremba @owais @ocelotl @lzchen