Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove http.status_text from span attributes #406

Merged
merged 7 commits into from
Apr 8, 2021
Merged

Remove http.status_text from span attributes #406

merged 7 commits into from
Apr 8, 2021

Conversation

srikanthccv
Copy link
Member

Description

http.status_text was removed in this spec pr open-telemetry/opentelemetry-specification#972

@srikanthccv srikanthccv requested a review from a team as a code owner April 5, 2021 13:46
@srikanthccv srikanthccv requested review from codeboten and ocelotl and removed request for a team April 5, 2021 13:46
codeboten
codeboten reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this change, I noticed some of the instrumentation uses the text from status_text in the status description, we should be consistent one way or the other about it.

...on/opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py Show resolved Hide resolved
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py Show resolved Hide resolved
...tation/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py Show resolved Hide resolved
@codeboten codeboten merged commit 370952f into open-telemetry:main Apr 8, 2021
owais pushed a commit to owais/opentelemetry-python-contrib that referenced this pull request Apr 13, 2021
@srikanthccv @aabmass @owais
Remove http.status_text from span attributes (open-telemetry#406)
4014879 
Update instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Update .github/workflows/test.yml

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srikanthccv @codeboten