Support request and response hooks for Django instrumentation #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
lzchen and
srikanthccv
and removed request for
a team
owais
force-pushed
the
instrumentation-hooks
branch
8 times, most recently
from
d4d466e
to
27ace6d
Compare
owais
commented
Apr 5, 2021
| @@ -11,6 +11,67 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| """ | |||
There was a problem hiding this comment.
Opportunistic update. Django was missing docs so copied from README.rst
|
We have couple of instrumentations where we let users set custom span name with |
|
I'd like to remove them at some point, yes, but not sure but much breakage it'll cause. Let's discuss that in the SIG meeting. |
|
Fixes #138 |
owais
force-pushed
the
instrumentation-hooks
branch
from
27ace6d
to
2489671
Compare
lzchen
approved these changes
Apr 5, 2021
owais
force-pushed
the
instrumentation-hooks
branch
from
2a22f73
to
ba1696a
Compare
owais
changed the title
owais
force-pushed
the
instrumentation-hooks
branch
2 times, most recently
from
adc515d
to
2e6c4d3
Compare
owais
force-pushed
the
instrumentation-hooks
branch
from
2e6c4d3
to
4f061dd
Compare
codeboten
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add request and response hooks support for Django instrumentation. This allows users to customize a bunch of things. Users can set custom span names, add additional attributes or other information to spans, inject tracing information into responses, etc.
Fixes #138
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.