Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Response hooks for Tornado server and client #422

Closed
wants to merge 1 commit into from

Conversation

owais
Copy link
Contributor

@owais owais commented Apr 7, 2021

Description

Adds support for request and response hooks to Falcon instrumentation. Given how tornado works, we only have a single hook that gets called once per request. It gets passed the active handler instead of request/response objects.

Fixes #132

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the tornado-hooks branch 8 times, most recently from 40ffd21 to 13797d9 Compare April 8, 2021 01:31
@owais owais marked this pull request as ready for review April 8, 2021 01:32
@owais owais requested a review from a team as a code owner April 8, 2021 01:32
@owais owais requested review from codeboten and lzchen and removed request for a team April 8, 2021 01:32
@owais owais force-pushed the tornado-hooks branch 5 times, most recently from 87c8272 to fc0979b Compare April 8, 2021 02:18
@owais owais closed this Apr 8, 2021
@owais owais deleted the tornado-hooks branch April 8, 2021 10:17
@owais owais restored the tornado-hooks branch April 8, 2021 10:17
@owais owais deleted the tornado-hooks branch April 8, 2021 10:17
@owais owais restored the tornado-hooks branch April 8, 2021 10:18
@owais
Copy link
Contributor Author

owais commented Apr 8, 2021

CI has been stuck and isn't working no matter what I try. Closing the PR and opening another one: #426

@owais owais deleted the tornado-hooks branch April 8, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add request and response hooks to tornado instrumentation
1 participant