Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core files to contrib #47

Closed

Conversation

NathanielRN
Copy link
Contributor

Description

This PR moves over many files from the Core repo so that they can live in the Contrib repo with a basic CI setup.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Adding CI validates dependency code from Core repos is installed correctly.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

alrex and others added 30 commits May 28, 2020 08:42
Set the sampling rate in the Datadog exported span if span was sampled with the ProbabilitySampler.

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
…pen-telemetry#652)

Adding an extension to provide users an easy mechanism to collect metrics for their system.
In PushController before exit, flush the meter by calling tick(), ensuring that all metrics are flushed.

Co-authored-by: alrex <aboten@lightstep.com>
This commit ports the OpenTracing testbed[1] to check that the ot-shim is
working as expected using different frameworks.

Gevent doesn't support context vars yet[2], so those tests are not compatible
with opentelemetry and were not ported.

[1] https://github.com/opentracing/opentracing-python/tree/master/testbed
[2] gevent/gevent#1407

Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io>
Co-authored-by: alrex <aboten@lightstep.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Co-authored-by: Cheng-Lung Sung <clsung@gmail.com>
Canonical codes for different types of exceptions

Span attributes extracted from exception

Correct span closing for requests with raised errors (A span wasn't closed due to a RequestException)

Co-authored-by: alrex <aboten@lightstep.com>
* Add lzchen to maintainers

Closes open-telemetry#778.

Co-authored-by: alrex <aboten@lightstep.com>
The span context is no longer coupled with the tracer itself.
As such, providing a get_current_span method bound to the
trace api module rather than a specific tracer is semantically
correct, and removes a hurdle where someone who wants to retrieve
the current trace would have to create a tracer to do so.

renaming and exporting get_span_in_context to get_current_span,
as the intention of the API is similar, and reduces unneeded
aliasing and duplication.

set_span_in_context is not renamed, as set_current_span would have
implied that the span would then be active in the default context,
which is only true after attaching the resulting context returned
by set_span_in_context. Keeping that name at least implies some
asymmetric behavior from get_current_span.

After discussion in the SIG, we decided to remove the
legacy get_current_span APIs from Tracer and TracerProvider
to reduce long-term confusion of how to idiomatically retrieve
the span.

Co-authored-by: alrex <aboten@lightstep.com>
Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io>
Co-authored-by: Andrew Xue <aaxue@google.com>
Co-authored-by: Cheng-Lung Sung <clsung@gmail.com>
Initial addition of opentelemetry-proto based protobufs.

Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver).

Co-authored-by: Chris Kleinknecht <libc@google.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Adding initial boto core implementation.

Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
eachdist.py did not support the installation of test packages,
(as defined by the extra_requires:test package group). As a
result, test packages were being added to dev-requirements.txt

By having eachdist.py develop install test packages, and moving
develop/test package definitions to the individual instrumentations,
it is easier to determine which packages require which dependencies
for testing purposes, and enables support for existing dependencies
that follow the extra_requires:test pattern.
@codeboten
Copy link
Contributor

This PR can be closed as it was broken into more small ones

@codeboten codeboten closed this Oct 26, 2020
@NathanielRN NathanielRN deleted the move-core-files-to-contrib branch November 2, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet