Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use traceflags object #472

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Use traceflags object #472

merged 5 commits into from
Apr 27, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 26, 2021

Fixes #471

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl requested a review from a team as a code owner April 26, 2021 22:45
@ocelotl ocelotl requested review from codeboten and lzchen and removed request for a team April 26, 2021 22:45
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 27, 2021
@ocelotl ocelotl self-assigned this Apr 27, 2021
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog to describe the bug that has been fixed.

@ocelotl ocelotl removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 27, 2021
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lzchen lzchen merged commit bdbc249 into open-telemetry:main Apr 27, 2021
@ocelotl ocelotl deleted the issue_471 branch April 27, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTracing propagator does not use a TraceFlags object
3 participants