Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traced_request_attrs #473

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Fix traced_request_attrs #473

merged 4 commits into from
Apr 29, 2021

Conversation

dtaniwaki
Copy link
Contributor

@dtaniwaki dtaniwaki commented Apr 27, 2021 •
edited
Loading

Description

traced_request_attrs cannot be passed by the instrumentation arguments.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@dtaniwaki dtaniwaki marked this pull request as ready for review April 29, 2021 08:30
@dtaniwaki dtaniwaki requested a review from a team as a code owner April 29, 2021 08:30
@dtaniwaki dtaniwaki requested review from codeboten and srikanthccv and removed request for a team April 29, 2021 08:30
codeboten
codeboten approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeboten codeboten merged commit 43e0972 into open-telemetry:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@codeboten codeboten codeboten approved these changes

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtaniwaki @owais @codeboten