Set status code on ASGI server span #478
Conversation
jomasti
requested review from
owais and
hectorhdzg
and removed request for
a team
| @@ -225,8 +225,10 @@ async def wrapped_send(message): | |||
| if send_span.is_recording(): | |||
| if message["type"] == "http.response.start": | |||
| status_code = message["status"] | |||
| set_status_code(span, status_code) | |||
| set_status_code(send_span, status_code) | |||
There was a problem hiding this comment.
Does send here mean sending a response back to the client?
Can the op represented by the outer span have multiple sends or receives?
There was a problem hiding this comment.
As far as I know, the callable will be called once per connection, which is one request for HTTP. That should mean only one http.response.start event. Happy to make a change if that is wrong.
There was a problem hiding this comment.
I believe multiple calls to receive and send can occur per HTTP call like from this issue. Should the parent span then reflect ANY error that occurs during the flow? If this is the case, we probably need the response code logic in the receive as well.
There was a problem hiding this comment.
Yes, there are multiple send events, but the second one is the response body, and that event does not have another status code.
There was a problem hiding this comment.
@owais
As discussed in the SIG meeting on 05/13/2021, we were wondering why there is a parent span for the channel in the first place? Would it be possible to remove this?
There was a problem hiding this comment.
I'll do a deep dive into ASGI and get back to this. As far as I understand right now, I think the receive span should be the SERVER span and "send" span should be it's child or grandchild. Both of these spans should use links to establish a relation with the channel span. I need some time to dig into this and confirm if my understanding is correct.
|
LGTM. It makes sense for the status code to be on the server span for HTTP requests. We do however need to re-work this instrumentation when it comes to websockets. Ticket to track/discuss it: #505 |
Description
Set the status code on the ASGI server span so that the proper response status code is displayed when exported to something like Azure Monitor
Fixes #427
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.