Fix tornado instrumentation's usage of Span Status #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
fix-tornado-set-span
branch
3 times, most recently
from
f792f1e
to
f23529c
Compare
owais
requested review from
codeboten and
srikanthccv
and removed request for
a team
Tornado will only set Status description if the accompanying status_code is an error status.
owais
force-pushed
the
fix-tornado-set-span
branch
from
f23529c
to
151c1d7
Compare
srikanthccv
approved these changes
May 22, 2021
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…telemetry/instrumentation/tornado/__init__.py Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
lzchen
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tornado will only set Status description if the accompanying status_code
is an error status.
Fixes: #500
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.