Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor httpx instrumentation #577

Merged
merged 24 commits into from
Jul 14, 2021
Merged

Refactor httpx instrumentation #577

merged 24 commits into from
Jul 14, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jul 12, 2021

Fixes #554

Instead of wrapping send, replace client classes with instrumented versions, similar to flask.

@lzchen lzchen requested a review from a team as a code owner July 12, 2021 21:00
@lzchen lzchen requested review from owais and aabmass and removed request for a team July 12, 2021 21:00
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeboten codeboten merged commit 9206e5d into open-telemetry:main Jul 14, 2021
@lzchen lzchen deleted the httpx branch July 14, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPX instrumentor wraps transport repeatedly
3 participants