-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Doc for aws propagator default sampling behavior #658
Conversation
Co-authored-by: Nathaniel Ruiz Nowell <enowell@amazon.com>
Hm interesting, maybe because I am part of the commit history I didn't get set a reviewer even though I am a CODEOWNER? But I can still give an approving review? |
May be. I think we should update the check so that it is only required when the author is not a code-owner. |
Also it looks like the "Component Owners" test is failing 😕 @lzchen
|
Yeah sorry, totally didn't think of that when giving you the co-author @NathanielRN |
No worries at all @willarmiros ! I think it's useful to see what this action does. We know the CODEOWNER works and the test passes from #657, but we should figure out the change in this PR. @lzchen had a good idea that this is because it's from your fork wheras #657 was from an upstream branch. I remember seeing the |
Closing in favor of #656 now that we checked the CODEOWNERs tool is working as expected. |
I... this was really confusing. The file diff made it look like this was being added in a different place lol |
Ah really sorry about that! Testing CODEOWNERs got in the middle of me deciding the change would fit better at a different point in the docs 😓 I really appreciate your green check mark! Especially since it helped me realize I should've closed this one immediately once #656 got merged but better late than never I guess 😅 |
Description
Dupe of #656, for also testing CODEOWNERS