botocore: Fix span inject for lambda invoke #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* for lambda invoke span injection happend to early which resulted in the botocore span being injected instead of the actual botocore span
codeboten
approved these changes
Sep 8, 2021
owais
approved these changes
Sep 8, 2021
nstawski
pushed a commit
to nstawski/ns-opentelemetry-python-contrib
that referenced
this pull request
May 10, 2023
…en-telemetry#1036) This commit extends the instrument command so it automatically configures tracing with a provider, span processor and exporter. Most of the component used can be customized with env vars or CLI arguments. Details can be found on opentelemetry-instrumentation's README package. Fixes open-telemetry#663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Span injection for lambda invoke in the botocore instrumentation happened before the botocore span was actually created which resulted in injecting the parent span instead of the actual botocore span.
This PR fixes span injection to inject the actual botocore span.
Type of change
How Has This Been Tested?
Adapted existing unit test
Does This PR Require a Core Repo Change?
Checklist: