botocore: Fix uninstrument to also unpatch header injection on Endpoint #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* botocore.endpoint.Endpoint.prepare_request is patched in the instrument method but unpatching it in the uninstrument method was missing
owais
approved these changes
Sep 7, 2021
|
Not sure what the deal with the CLA check was... looks like its fixed now. |
lzchen
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
botocore instrumentor is patching
botocore.endpoint.Endpoint.prepare_reqyestin the instrument method but did not unpatch it in the uninstrument method.Type of change
How Has This Been Tested?
Additional unit test was added
Does This PR Require a Core Repo Change?
Checklist: