adding response_hook to redis instrumentor #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItayGibel-helios
force-pushed
the
redis_response_hook
branch
from
14b88eb
to
7fc376e
Compare
ocelotl
approved these changes
Sep 9, 2021
lzchen
reviewed
Sep 13, 2021
| ) | ||
| return func(*args, **kwargs) | ||
| def _instrument( | ||
| tracer, response_hook: _ResponseHookT = None, |
There was a problem hiding this comment.
Should there be a request_hook callback as well? A callable that is executed before the request is made, similar to the hooks in http instrumentaitons.
lzchen
reviewed
Sep 13, 2021
| @@ -41,8 +41,8 @@ | |||
| API | |||
| --- | |||
| """ | |||
There was a problem hiding this comment.
Could you add an example usage of the hooks in the docstrings?
ItayGibel-helios
force-pushed
the
redis_response_hook
branch
from
8b72ee1
to
8177f26
Compare
lzchen
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-instrumentation-redis: added response_hook callback passed as an argument to the instrument method, enabling the users to add data from the response to the span attributesType of change
Please delete options that are not relevant.
How Has This Been Tested?
test_response_hook- a new unit test testing the hook activationDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.