Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTPClientInstrumentor instrumentation entry point #745

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Oct 15, 2021

Description

Fixes #744

This is a temporary hotfix for the issue linked above. We'll need to
figure out a proper fix later.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team as a code owner October 15, 2021 18:13
Fixes open-telemetry#744

This is a temporary hotfix for the issue linked above. We'll need to
figure out a proper fix later.
@owais owais force-pushed the fix-opentelemetry-util-http branch from b2a4c54 to e4cb012 Compare October 15, 2021 18:15
@owais owais merged commit 8ad84a5 into open-telemetry:main Oct 15, 2021
@owais owais deleted the fix-opentelemetry-util-http branch October 15, 2021 18:45
nicholasgribanov pushed a commit to nicholasgribanov/opentelemetry-python-contrib that referenced this pull request Oct 29, 2021
…etry#745)

Fixes open-telemetry#744

This is a temporary hotfix for the issue linked above. We'll need to
figure out a proper fix later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

util-http breaks auto-instrumentation since v0.25b0
4 participants