Remove unnecessary deps on test pkgs #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
remove-unnecessary-deps-on-test
branch
from
29b3f8d
to
77a74a8
Compare
lzchen
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We just found out that the
opentelemetry-sdk-extension-awsandopentelemetry-propagator-aws-xraypackages do not need to depend on theopentelemetry-testpackage.We remove their dependencies in this PR.
Since it is removing a dependency and not adding one, we can release these packages as _patch` updates.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
opentelemetry-testtox -e test-sdkextensionawsandtox -e test-propagator-awsDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [] Unit tests have been added