Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate instrumentation documentation in docstrings #754

Merged
merged 31 commits into from
Oct 21, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Oct 18, 2021

Updates instrumentation docstrings to include section on configuration. Most are related to exclude_url functionality and request/response hooks. We want all of our documentation to exist in one place (readthedocs).

@lzchen lzchen requested a review from a team as a code owner October 18, 2021 22:54
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a decision made to add the documentation here? Is this duplicating existing documentation?

@lzchen
Copy link
Contributor Author

lzchen commented Oct 19, 2021

@codeboten
I believe configuration options for instrumentations either exist in the README or in the docstrings of the instrumentation. We should choose one place and be consistent. Only choosing README in this PR because it seemed easier to find (from some feedback) but I don't have a strong opinion. Thoughts?

@lzchen lzchen changed the title Update instrumentation docs to include configuration sections Consolidate instrumentation documentation in docstrings Oct 20, 2021
@owais
Copy link
Contributor

owais commented Oct 20, 2021

Will removing docstrings mean removing the docs from readthedocs?

Read the description again. 👍 for keeping read the docs. We could also have our 4th generate script that allows us to keep docstrings as the single source of truth and generate everything else from that but this is fine as well as long as readthedocs contains the docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming this is moving all the documentation that would have ended up on pypi into the read the docs repo correct? Users should be able to access it via the links in each package.

@lzchen
Copy link
Contributor Author

lzchen commented Oct 20, 2021

@codeboten

Just confirming this is moving all the documentation that would have ended up on pypi into the read the docs repo correct? Users should be able to access it via the links in each package.

Correct.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, looks like a few things need fixing, otherwise the change looks great.

@lzchen
Copy link
Contributor Author

lzchen commented Oct 20, 2021

@owais

We could also have our 4th generate script that allows us to keep docstrings as the single source of truth and generate everything else from that but this is fine as well as long as readthedocs contains the docs.

Haha so many generate scripts xD

@codeboten
Copy link
Contributor

@owais

We could also have our 4th generate script that allows us to keep docstrings as the single source of truth and generate everything else from that but this is fine as well as long as readthedocs contains the docs.

Haha so many generate scripts xD

Soon we'll generate scripts via a generate script
5r7ki1
.

@lzchen lzchen merged commit ae7a415 into open-telemetry:main Oct 21, 2021
@lzchen lzchen deleted the docs branch October 21, 2021 16:54
nicholasgribanov pushed a commit to nicholasgribanov/opentelemetry-python-contrib that referenced this pull request Oct 29, 2021
nicholasgribanov pushed a commit to nicholasgribanov/opentelemetry-python-contrib that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants