Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/instrument basic publish in pika #759

Conversation

oxeye-nikolay
Copy link
Member

Description

The bugfix fixes the following flow:

PikaInstrumentor().instrument()
connection = pika.BlockingConnection(parameters)
channel = connection.channel()
channel.basic_consume(queue='helloworld', on_message_callback=callback, auto_ack=True)

In this flow, the newly added callback is not decorated because basic_consume was not wrapped.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Using the provided snippet and a ConsoleExporter

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@oxeye-nikolay oxeye-nikolay self-assigned this Oct 19, 2021
@oxeye-nikolay oxeye-nikolay requested a review from a team as a code owner October 19, 2021 11:09
@lzchen lzchen merged commit c24c77d into open-telemetry:main Oct 19, 2021
nicholasgribanov pushed a commit to nicholasgribanov/opentelemetry-python-contrib that referenced this pull request Oct 29, 2021
nicholasgribanov pushed a commit to nicholasgribanov/opentelemetry-python-contrib that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants