Bugfix: Pika basicConsume context propagation #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the context propegation to consumer callback. Bug was fix by attaching and detaching the context before executing the user callback. Hook location was changed to hook the user callback and not the async enqeueuing of messages.
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py
Outdated
Show resolved
Hide resolved
oxeye-nikolay
approved these changes
Oct 21, 2021
lzchen
approved these changes
Oct 21, 2021
nicholasgribanov
pushed a commit
to nicholasgribanov/opentelemetry-python-contrib
that referenced
this pull request
Oct 29, 2021
nicholasgribanov
pushed a commit
to nicholasgribanov/opentelemetry-python-contrib
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the context propagation to consumer callback.
Description
The bug was fixed by attaching and detaching the context before executing the user callback.
Hook location was changed to hook the user callback and not the async enqueuing of messages.
Fixes # (issue)
Fixing context propagation to other instrumentors executed from inside the basicConsume callback.
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: