Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools instrumentation install requirement #781

Commits on Oct 26, 2021

  1. Add setuptools instrumentation install requirement

    The `setuptools` package is not part of the stdlib, but often available
    in the system environment (it is a buildtime requirement).
    
    `pkg_resources` (a package provided by `setuptools`) is used as
    a runtime requirement in `opentelemetry-instrumentation`. Explicitly
    listing `setuptools` as a requirement protects instrumentation from
    breaking with import errors in cases where `setuptools` is not available
    system-wide.
    
    For example:
    
    * A multi-stage Docker build where the final image does not contain
    buildtime requirements.
    * A build system that packages the runtime dependencies into a single
    binary.
    
    This commit pins `setuptools >= 16.0` because that is the first release
    that included all 5 imports instrumentation currently relies on.
    mattoberle committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    39ae6e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Configuration menu
    Copy the full SHA
    9a50d5d View commit details
    Browse the repository at this point in the history