Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support instrumentation for Tornado 5.1.1 #812

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

nicholasgribanov
Copy link
Contributor

Description

Now tornado-instrumentaion support only Tornado version more than 6.0, but in instrumentation code not anything specifics for Tornado 6 there are. There is release note for Tornado 6.0, and noone backwards-incompatible changes using in actual implementation of instumentation. I've tested Tornado instrumentation for last 5s version (5.1.1) in my highload project for this version and it works for me. Alternative way, using opentracing instead of opentelemetry, is not quite good, because a lot of part of microserfices may using opentelemetry for Java, Go and different languages. For more complecevity good reason for using opentelemetry for old tornado version.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Run current tests for Tornado 5.1.1 on Python 3.8.10. Start up on highload service (8000 rps) on pythonv 3.8.10. Check generated span and send throgh OTL. As a result - see span on Jaeger.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added. Not reasons for add new tests
  • Documentation has been updated

@nicholasgribanov nicholasgribanov requested a review from a team as a code owner November 17, 2021 11:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 17, 2021

CLA Signed

The committers are authorized under a signed CLA.

@owais owais enabled auto-merge (squash) November 17, 2021 17:22
@owais owais merged commit e6dff7e into open-telemetry:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants