Support partial timelimit for celery tasks #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codeboten
reviewed
Jan 10, 2022
There was a problem hiding this comment.
hey @OHeimlich, thanks for the contribution! Please make sure to sign the CLA and update the changelog to include a note about the fix.
srikanthccv
reviewed
Jan 10, 2022
...ation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/utils.py
Show resolved
Hide resolved
|
|
|
OHeimlich
force-pushed
the
support-partial-timelimit
branch
from
47bd9c5
to
4aea260
Compare
|
Hey @codeboten, |
OHeimlich
requested review from
codeboten and
srikanthccv
and removed request for
a team
…telemetry-python-contrib into support-partial-timelimit
srikanthccv
approved these changes
Jan 24, 2022
codeboten
approved these changes
Jan 25, 2022
sanketmehta28
pushed a commit
to sanketmehta28/opentelemetry-python-contrib
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support in partial time limit for celery tasks.
Instrument celery task time limit even if only one limit was set (soft/hard limit).
Fixes #846
Type of change
How Has This Been Tested?
Running unit test
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.