Changed the format of traceparent id

[Thiyagu55]

Changed the format of traceparent id

Compressed the format of traceparent id from /*span_id=16659691402252420308,trace_flags=1,trace_id=283190570959089573593920162873354610508,trace_state=''*/ to /*traceparent='00-91be8b5a37d16542524ae5ae0907ec5f-543bfa9675358c75-1'*/

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

• tox -e test-instrumentation-dbapi

Does This PR Require a Core Repo Change?

• Yes. - Link to PR

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated

[ocelotl]

What issue is being fixed by this PR, @Thiyagu55 ?

[Thiyagu55]

What issue is being fixed by this PR, @Thiyagu55 ?

@ocelotl This is not a bug fix issue.
Changed the format of traceparent id in query log

[ocelotl]

What issue is being fixed by this PR, @Thiyagu55 ?

@ocelotl This is not a bug fix issue. Changed the format of traceparent id in query log

Ok, I should rephrase. What is the motivation behind this PR? Why do we want to add this change?

Just to be clear, I am by no means rejecting this PR or considering it not necessary, I just want to know the reasons behind it. ✌️

[srikanthccv]

@ocelotl The current format is not complaint with the commenter specification. This change fixes it.

[lzchen]

@Thiyagu55
Could you link to the section of the sqlcommenter documentation in which it specifies the format of traceparent?

[Thiyagu55]

@Thiyagu55
Could you link to the section of the sqlcommenter documentation in which it specifies the format of traceparent?
@lzchen https://open-telemetry.github.io/opentelemetry-sqlcommenter/

[lzchen]

Nit: Can you use f strings for this

[lzchen]

@srikanthccv
Do you think _generate_sql_comment would always be used in conjuction with _generate_opentelemetry_traceparent? Is it necessary to separate these?

[srikanthccv]

@lzchen traceparent header is only part of the comment, there can be more info embedded in the comment such as request route. I think it is fine they are separate.