fix: [kafka-python] support topic as kwarg #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozik
force-pushed
the
kafka_python_topic_extraction_fix
branch
from
75660e0
to
82101d6
Compare
nozik
changed the title
nozik
changed the title
nozik
force-pushed
the
kafka_python_topic_extraction_fix
branch
6 times, most recently
from
2a809cf
to
d1740bf
Compare
nozik
force-pushed
the
kafka_python_topic_extraction_fix
branch
from
d1740bf
to
16feb85
Compare
lzchen
approved these changes
Mar 10, 2022
|
@lzchen Can this be merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Topic was only extracted when sent as regular arg; it can also be provided as a kwarg.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a test case
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.