-
Notifications
You must be signed in to change notification settings - Fork 579
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Design Decisions include: The API package should be minimal, and example implementations should live in SDK when possible. The precedent that exists is to name both the interface and the implementation in the sdk the same. This avoids the generally unhelpful "Default" prefix. opentelemetry-python is standardizing on Google style docstrings. As such resolving formatting that is inconsistent with the style guilde.
- Loading branch information
1 parent
7c5e018
commit e3f8ef0
Showing
4 changed files
with
116 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Copyright 2019, OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import opentelemetry.resources as resources | ||
|
||
|
||
class Resource(resources.Resource): | ||
def __init__(self, labels): | ||
self._labels = labels | ||
|
||
@staticmethod | ||
def create(labels): | ||
return Resource(labels) | ||
|
||
@property | ||
def labels(self): | ||
return self._labels | ||
|
||
def merge(self, other): | ||
if other is None: | ||
return self | ||
if not self._labels: | ||
return other | ||
merged_labels = self.labels.copy() | ||
for key, value in other.labels.items(): | ||
if key not in merged_labels or merged_labels[key] == "": | ||
merged_labels[key] = value | ||
return Resource(merged_labels) | ||
|
||
def __eq__(self, other: object) -> bool: | ||
if not isinstance(other, Resource): | ||
return False | ||
return self.labels == other.labels |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import unittest | ||
from opentelemetry.sdk import resources | ||
|
||
|
||
class TestResources(unittest.TestCase): | ||
def test_resource_merge(self): | ||
left = resources.Resource({"service": "ui"}) | ||
right = resources.Resource({"host": "service-host"}) | ||
self.assertEqual( | ||
left.merge(right), | ||
resources.Resource({ | ||
"service": "ui", | ||
"host": "service-host" | ||
})) | ||
|
||
def test_resource_merge_empty_string(self): | ||
"""Verify Resource.merge behavior with the empty string. | ||
Labels from the source Resource take precedence, with | ||
the exception of the empty string. | ||
""" | ||
left = resources.Resource({"service": "ui", "host": ""}) | ||
right = resources.Resource({ | ||
"host": "service-host", | ||
"service": "not-ui" | ||
}) | ||
self.assertEqual( | ||
left.merge(right), | ||
resources.Resource({ | ||
"service": "ui", | ||
"host": "service-host" | ||
})) |