Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger exporter must report instrumentation info #1092

Closed
codeboten opened this issue Sep 10, 2020 · 2 comments · Fixed by #1098
Closed

Jaeger exporter must report instrumentation info #1092

codeboten opened this issue Sep 10, 2020 · 2 comments · Fixed by #1098
Assignees
@euniceek
Labels
exporters good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
GA Burndown

Comments

@codeboten
Copy link
Contributor

codeboten commented Sep 10, 2020 •
edited

As per spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/jaeger.md#instrumentationlibrary

The instrumentation name and version must be reported by the exporter
@codeboten codeboten added good first issue Good first issue exporters help wanted release:required-for-ga To be resolved before GA release labels Sep 10, 2020
@codeboten codeboten changed the title Jaeger exporter should report instrumentation info Jaeger exporter must report instrumentation info Sep 10, 2020
@dengliming dengliming mentioned this issue Sep 11, 2020
Merged
@codeboten codeboten added this to In Progress in GA Burndown Sep 14, 2020
@euniceek
Copy link
Contributor

Hey, could I pick this up? I am looking for a good first issue to work on!

@codeboten
Copy link
Contributor Author

Yes absolutely @eunice98k, assigning it to you. Thanks!

GA Burndown automation moved this from In Progress to Done Sep 15, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan
chore: 0.8.2 release proposal (open-telemetry#1092)
7233a03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@euniceek euniceek

Labels
exporters good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
No open projects
GA Burndown
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jaeger exporter report instrumentation info dengliming/opentelemetry-python
2 participants
@codeboten @euniceek