Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OTEL_TRACE_* to OTEL_TRACES_* #1566

Closed
codeboten opened this issue Feb 2, 2021 · 4 comments · Fixed by #1595
Closed

Rename OTEL_TRACE_* to OTEL_TRACES_* #1566

codeboten opened this issue Feb 2, 2021 · 4 comments · Fixed by #1595
Assignees
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

As per the spec change: open-telemetry/opentelemetry-specification#1382

@codeboten codeboten added the bug Something isn't working label Feb 2, 2021
@lzchen
Copy link
Contributor

lzchen commented Feb 2, 2021

Are we renaming everything from trace -> traces in the code (like directories, docstrings, etc)?

@srikanthccv
Copy link
Member

Are we renaming everything from trace -> traces in the code (like directories, docstrings, etc)?

I think it is just env variables for consistency with metrics and logs.

@lzchen
Copy link
Contributor

lzchen commented Feb 4, 2021

I think it is just env variables for consistency with metrics and logs.

Yes but the question is, should be rename everything to be consistent so users are not confused?

@lzchen
Copy link
Contributor

lzchen commented Feb 4, 2021

Discussed in 02/04/2021 SIG, we will just stick to renaming env vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants