Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename env vars from OTEL_TRACE -> OTEL_TRACES #1595

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Rename env vars from OTEL_TRACE -> OTEL_TRACES #1595

merged 2 commits into from
Feb 11, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 11, 2021

Fixes #1566

@lzchen lzchen requested a review from a team as a code owner February 11, 2021 18:55
@lzchen lzchen requested review from toumorokoshi and ocelotl and removed request for a team February 11, 2021 18:55
hectorhdzg
hectorhdzg approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 84b1b0c into open-telemetry:main Feb 11, 2021
@lzchen lzchen deleted the traces branch February 11, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename OTEL_TRACE_* to OTEL_TRACES_*
3 participants
@lzchen @codeboten @hectorhdzg