Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagators: specify case sensitivity of get_from_carrier #214

Closed
mauriciovasquezbernal opened this issue Oct 10, 2019 · 3 comments
Closed
Assignees
Labels
sdk Affects the SDK package. tracing

Comments

@mauriciovasquezbernal
Copy link
Member

The w3c specification states that the implementation must ignore the case of the traceparent header name: https://www.w3.org/TR/trace-context/#header-name.

The current implementation just calls get_from_carrier without further info about the case:

header = get_from_carrier(carrier, cls._TRACEPARENT_HEADER_NAME)
.

Probably we'll need to add a new parameter to get_from_carrier that specifies if the case must be considered or not.

Related: #197, #125

@Oberon00
Copy link
Member

Oberon00 commented Oct 10, 2019

I think that get_from_carrier should be the one to decide if case is important, not the caller/propagator. EDIT: E.g. HTTP headers are case-insensitive but some messaging system properties might not be.

@Oberon00
Copy link
Member

Oberon00 commented Nov 11, 2019

Will be resolved with open-telemetry/opentelemetry-specification#346

@mauriciovasquezbernal
Copy link
Member Author

mauriciovasquezbernal commented Jan 14, 2020

Closing as open-telemetry/opentelemetry-specification#346 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Affects the SDK package. tracing
Projects
None yet
Development

No branches or pull requests

2 participants