Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using __setitem__ / __getitem__ instead of explicit setters / getters for propagators #125

Closed
toumorokoshi opened this issue Sep 6, 2019 · 2 comments
Closed

Consider using __setitem__ / __getitem__ instead of explicit setters / getters for propagators #125

toumorokoshi opened this issue Sep 6, 2019 · 2 comments
Labels
api Affects the API package.

Comments

@toumorokoshi
Copy link
Member

Based on this comment: #121 (comment)

We could probably just use convention to the setitem / getitem API and remove the need for the setter / getter functions as dictated by the propagators API.
@Oberon00 Oberon00 mentioned this issue Sep 12, 2019
Closed
@Oberon00
Copy link
Member

I'm for keeping explicit setters/getters as this is the most flexible API. But the user-facing API should accept mapping-like objects too.

@Oberon00 Oberon00 added the api Affects the API package. label Sep 24, 2019
Closed
@toumorokoshi
Copy link
Member Author

toumorokoshi commented Jan 14, 2020 •
edited
Loading

I'm going to close this issue as the context API is now changing dramatically with the new context propagation OTEP. Feedback around this should be sent to the OTEP: open-telemetry/oteps#66

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@OlivierAlbertini @mayurkale22
Update tracer interface (open-telemetry#125)
c225d84 
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close open-telemetry#124 open-telemetry#123

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toumorokoshi @Oberon00