Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build release from source distribution #252

Closed
c24t opened this issue Oct 29, 2019 · 3 comments · Fixed by #437
Closed

Build release from source distribution #252

c24t opened this issue Oct 29, 2019 · 3 comments · Fixed by #437
Labels
build & infra Issues related to build & infrastructure.

Comments

@c24t
Copy link
Member

c24t commented Oct 29, 2019

From @Oberon00's comment: #247 (comment).

Right now we build packages with python setup.py bdist_wheel, but we should consider using setup.py to build a source distribution and pip wheel to build the wheel.
@c24t c24t added the build & infra Issues related to build & infrastructure. label Oct 29, 2019
@c24t c24t mentioned this issue Oct 29, 2019
Merged
@c24t c24t mentioned this issue Jan 23, 2020
Closed
@allantw
Copy link

allantw commented Jan 28, 2020

Could the source distribution be pushed to pypi was well? Right now, it's just the wheel.

@Oberon00
Copy link
Member

Oberon00 commented Jan 29, 2020 •
edited
Loading

What would be the advantage of having the source distribution? It's a pure Python wheel anyway.

@allantw
Copy link

allantw commented Jan 29, 2020 •
edited
Loading

Unfortunately, it's an internal requirement for my organization to generate the build ourselves off of the source distribution.

@Oberon00 Oberon00 mentioned this issue Feb 18, 2020
Closed
@c24t c24t mentioned this issue Feb 20, 2020
Merged
@c24t c24t closed this as completed in #437 Feb 20, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
feat(Node-Tracer): initialize plugin loader (open-telemetry#252)
03ef951 
* fix: init plugin loader

* fix: add tests

* fix: user afterEach to stop the tracer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build & infra Issues related to build & infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build wheels from source dists open-telemetry/opentelemetry-python
3 participants
@Oberon00 @allantw @c24t