Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL_METRICS_EXPORTER implementation #2740

Closed
TBBle opened this issue Jun 6, 2022 · 4 comments
Closed

OTEL_METRICS_EXPORTER implementation #2740

TBBle opened this issue Jun 6, 2022 · 4 comments

Comments

@TBBle
Copy link
Contributor

TBBle commented Jun 6, 2022

Is your feature request related to a problem?

You cannot create a metrics exporter pipeline with environment variables.

Describe the solution you'd like

The OpenTelemetry-standardised OTEL_METRICS_EXPORTER should be implemented for its "known values".

It'd be nice if as well as the "known values", a value was chosen for the "In-memory Metrics Exporter". I haven't looked around at other SDKs to see if they do this, but in this SDK, that's implemented as an InMemoryMetricReader instead, so this might be more complex, and require some extra variables, similar to the OTEL_PYTHON_METER_PROVIDER environment variable, or a simple InMemoryMetricExporter that wraps the InMemoryMetricReader. (Alternatively, convert the InMemoryMetricReader to be a spec-compliant "In-memory Metrics Exporter" that works with PeriodicExportingMetricReader, I guess, or pull the existing one out of the test suite and clean it up a bit.)

Describe alternatives you've considered

We have to do all our metrics setup in the code, which requires plumbing our configuration through from the environment (or test suite hosting system).

Additional context

Structurally, I assume it would be added in the same place as the OTEL_TRACES_EXPORTER and OTEL_LOGS_EXPORTER are handled.

Okay, I had a quick look around, and possibly only the Java SDK has an InMemoryMetricExporter implementation, unless the spelling is different and fooled GitHub search. A few things implement OTEL_METRICS_EXPORTER for otlp and none though, e.g. the .NET and PHP SDKs.

@lzchen
Copy link
Contributor

lzchen commented Jun 7, 2022

Should be address by: #2705

@TBBle
Copy link
Contributor Author

TBBle commented Jun 8, 2022

#2705 has delivered the support for processing OTEL_METRICS_EXPORTER, but there is still another PR to go to add opentelemetry_metrics_exporter entry points for the SDK-provided exporters. Particularly since ConsoleMetricsExporter is still broken (#2716), and we don't have an InMemoryMetricsExporter.

@srikanthccv
Copy link
Member

There won't be another InMemoryMetricsExporter component. See the #2539 for prior context. The ConsoleMetricsExporter bug is addressed here #2722 .

@srikanthccv
Copy link
Member

Configuration is updated #1705, entry points are added #2748, and default grpc exporter set for opentelemetry-instrument open-telemetry/opentelemetry-python-contrib#1127. Closing this since all of relevant work is done. Feel free to re-open if something is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants