Add missing to_json methods #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
force-pushed
the
issue_2716
branch
2 times, most recently
from
3090f94
to
3824022
Compare
lzchen
reviewed
May 31, 2022
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
May 31, 2022
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
May 31, 2022
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Jun 8, 2022
lzchen
approved these changes
Jun 8, 2022
|
@ocelotl Just want to say THANK YOU for fixing this! I had spent a bit of time trying to get Metrics to work this week, literally hours after you had committed the fix to your own repo, pulling that in and installing from git branch. Now that it's in :main, how long to you think before another PyPi RC will be posted? |
|
@paulsbruce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2716