Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ExponentialBucketHistogramAggregation in opentelemetry.sdk.metrics.view #3239

Closed
sk- opened this issue Mar 25, 2023 · 0 comments · Fixed by #3240
Closed

Export ExponentialBucketHistogramAggregation in opentelemetry.sdk.metrics.view #3239

sk- opened this issue Mar 25, 2023 · 0 comments · Fixed by #3240

Comments

@sk-
Copy link
Contributor

sk- commented Mar 25, 2023

Is your feature request related to a problem?
We want to use the Exponential Histograms features publicly released in version 1.17.0.

Describe the solution you'd like
I'd like to use the public API.

Describe alternatives you've considered
One can import it from opentelemetry.sdk.metrics._internal.aggregation

Additional context
Currently the code in

__all__ = [
"Aggregation",
"DefaultAggregation",
"DropAggregation",
"ExplicitBucketHistogramAggregation",
"LastValueAggregation",
"SumAggregation",
"View",
]
is not exporting the newly added ExponentialBucketHistogramAggregation

sk- added a commit to sk-/opentelemetry-python that referenced this issue Mar 25, 2023
…sdk.metrics.view

Without this PR if one wants to use exponential histrograms, which were added in realease 1.17.0 (https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md#version-1170038b0-2023-03-22), one needs to import it from the private package opentelemetry.sdk.metrics._internal.aggregation.

This PR fixes open-telemetry#3239.
srikanthccv pushed a commit that referenced this issue Mar 29, 2023
…sdk.metrics.view (#3240)

* fix: export ExponentialBucketHistogramAggregation from opentelemetry.sdk.metrics.view

Without this PR if one wants to use exponential histrograms, which were added in realease 1.17.0 (https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md#version-1170038b0-2023-03-22), one needs to import it from the private package opentelemetry.sdk.metrics._internal.aggregation.

This PR fixes #3239.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant