-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test in opentelemetry-sdk #3911
Labels
bug
Something isn't working
Comments
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
May 30, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 To remove some flakyness round to milliseconds the time difference. Fix open-telemetry#3911
11 tasks
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 3, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 We should probably revise all these skip on Windows Pypy once we have a Python 3.9 baseline and Pypy >= 7.3.12. Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 12, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (places=1) and avoid too big values. Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 12, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (places=0) and avoid too big values. Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 13, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (delta=1) and avoid too big values. Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 13, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (delta=16) and avoid too big values. Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 13, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (delta=16) and avoid too big values. Skip tests on windows pypy because of random huge spikes: E AssertionError: 2253.103017807007 != 500 within 16 delta (1753.1030178070068 difference) Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 13, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (delta=20) and avoid too big values. Skip tests on windows pypy because of random huge spikes: E AssertionError: 2253.103017807007 != 500 within 20 delta (1749.1030178070068 difference) Fix open-telemetry#3911
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this issue
Jun 13, 2024
It happened that tests failed because the delay was fired some microseconds earlier: > self.assertGreaterEqual((export_time - start_time) * 1e3, 500) E AssertionError: 499.9737739562988 not greater than or equal to 500 Use assertAlmostEqual to accept a similar enough value (delta=25) and avoid too big values. Skip tests on windows pypy because of random huge spikes: E AssertionError: 2253.103017807007 != 500 within 25 delta (1744.1030178070068 difference) Fix open-telemetry#3911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your environment
Flaky test in CI, we are asserting that the time will be greater than 500 but in this run it was less than that. We could probably use
assertAlmostEqual
instead.Steps to reproduce
tox -e pypy3-opentelemetry-sdk
What is the expected behavior?
Test will pass everytime
What is the actual behavior?
Test is flaky
Additional context
The text was updated successfully, but these errors were encountered: