Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Readiness Tracker #418

Closed
32 of 34 tasks
codeboten opened this issue Feb 13, 2020 · 8 comments
Closed
32 of 34 tasks

Beta Readiness Tracker #418

codeboten opened this issue Feb 13, 2020 · 8 comments
Milestone

Comments

@codeboten
Copy link
Contributor

codeboten commented Feb 13, 2020

This is a tracking issue for the requirements outlined in the beta release doc: https://docs.google.com/document/d/1eviggoIguOS89dgKL-8ntUOCfPP6FLWAoQkGoBDsld0/edit#

Traces

  • stable API of every spec'd feature
  • SDK Implementation of every spec'd feature

Metrics

Resources

Context Propagation

Exporters

Integrations

Examples

  • manual tracing hello world example
  • http client/server using an instrumented framework
  • gRPC client/server Add gRPC integration #276
@codeboten codeboten added this to the beta milestone Feb 13, 2020
@codeboten codeboten pinned this issue Feb 13, 2020
@Oberon00
Copy link
Member

There is one important and rather basic thing that's missing here: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-resource.md

@codeboten
Copy link
Contributor Author

That's a good point, I didn't see anything in the JS beta tracker, or in the OpenTelemetry Launch Plan about resources. Do you have anymore info on this @mtwo?

@mtwo
Copy link
Member

mtwo commented Feb 15, 2020

Resource metadata is required; @bogdandrutu or @carlosalberto can confirm. I've updated the launch plan doc to reflect this.

@dyladan can you update the JS beta tracker to reflect this?

@codeboten
Copy link
Contributor Author

Section for resources was added.

@toumorokoshi
Copy link
Member

After a discussion with @jmacd in gitter, I've clarified that the resource SDK today calls for 1. an implementation of resources and 2. a way to bind them into the Tracers that are created.

We have 1 already:

We do not yet have 2: https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py#L573

As it's still ambiguous what Resources will eventually be used for, and an OTEP around Resources in a broader term, Unless someone with more context can inform, we probably just need to be able to a handle to a Resource object to the traceprovider: open-telemetry/oteps#78

@codeboten
Copy link
Contributor Author

@mtwo is the OpenTracing bridge still part of the beta requirement? It doesn't appear in the launch doc.

@mtwo
Copy link
Member

mtwo commented Mar 5, 2020

It's not a requirement for beta, though I think that a few languages will be including it anyways. I assume that we'll have it as a RC / GA requirement, though we haven't set these yet.

@c24t
Copy link
Member

c24t commented Mar 17, 2020

Moving the gRPC integration and examples forward to the next milestone and closing this one out.

@c24t c24t closed this as completed Mar 17, 2020
@codeboten codeboten unpinned this issue Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants