Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus exporter #157

Closed
c24t opened this issue Sep 20, 2019 · 8 comments · Fixed by #378
Closed

Add Prometheus exporter #157

c24t opened this issue Sep 20, 2019 · 8 comments · Fixed by #378
Assignees
Milestone

Comments

@c24t
Copy link
Member

c24t commented Sep 20, 2019

Add prometheus exporter to prove metrics SDK. Consider adding console exporter for metrics. This depends on metrics SDK work: #155.

@c24t c24t added this to the Alpha Release milestone Sep 20, 2019
@c24t c24t modified the milestones: Alpha Release, Alpha v0.2 Oct 11, 2019
@c24t c24t modified the milestones: Alpha v0.2, Alpha v0.3 Oct 31, 2019
@c24t c24t self-assigned this Oct 31, 2019
@rajibmitra
Copy link

is there any work left on this issue ? @c24t

@c24t c24t modified the milestones: Alpha v0.3, Alpha v0.4 Dec 16, 2019
@toumorokoshi
Copy link
Member

@rajibmitra work has not started on this yet, from what I can tell. @lzchen @c24t any issue with someone picking this up?

@lzchen
Copy link
Contributor

lzchen commented Dec 18, 2019

@toumorokoshi
I have not started on this yet. @c24t Any updates?
I will be also releasing an end-to-end for metrics SDK later this week.

@c24t
Copy link
Member Author

c24t commented Dec 20, 2019

@hectorhdzg you may be interested in this since it goes hand-in-hand with @lzchen's aggregation and export work.

@c24t
Copy link
Member Author

c24t commented Dec 20, 2019

@rajibmitra you're welcome to pick this up, but it relies on some ongoing work in #341. Are you interested in prometheus specifically, metrics in general, or just looking for interesting open issues?

@c24t
Copy link
Member Author

c24t commented Dec 20, 2019

See also open-telemetry/opentelemetry-go#334, which added the prometheus exporter in go before metrics aggregation was ready by using the prometheus lib to handle aggregation.

@rajibmitra
Copy link

I am just looking for interesting open issues, I am comfortable in python and go and k8s ecosystem
@c24t

@c24t c24t assigned hectorhdzg and unassigned c24t Jan 8, 2020
@c24t
Copy link
Member Author

c24t commented Jan 8, 2020

Assigning this one to @hectorhdzg at his request. @rajibmitra, come chat on gitter and we can find a good first issue for you.

@codeboten codeboten mentioned this issue Feb 13, 2020
34 tasks
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
* feat(plugin): add http plugin

Closes open-telemetry#157

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: integrate vmarchaud recommandations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: wip revert - gts fix issue on all packages

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: integrate mayurkale22 recommendations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* ci: gts fix for ci build

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* refactor: add mayurkale22 recommendations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: integrate bg451 recommendations

test: increase coverage
fix: attributes requirements from the spec.

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add missing header and revert scopeManager to private field

test: rename some tests
fix: copy/paste tests

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add tests and improve attributes from spec

fix parentSpanId instead of parentId from rebase
add workaround with got and node12+ (real http call)
improve args passed to function (url, options, cb)

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add mayurkale22 recommendations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: rebase and remove/replace wrapEmitter to bind

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add Flarna recommendations

fix: add Flarna recommendations
fix: tests
fix: OC bugs in OT only
test: add assertions
Allow options object as second argument

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* refactor: simplify propagation usage

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add Flarna recommandations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* refactor(test): use ReadableSpan

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* feat: export class/enums for https module

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* refactor: plugin.enable has logger param

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add license header, rename enum files and refactoring

refactor: make integration tests mandatory for ci only
remove duplicate tests
remove dead comments

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants