Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagator Class [POC for review] #121

Commits on Sep 2, 2019

  1. Changed to the propagator API

    Adding a UnifiedContext, composing DistributedContext and SpanContext.
    This will enable propagators to extract and inject values from either system,
    enabling more sophisticated schemes and standards to propagate data.
    
    This also removes the need for generics and propagators that only
    consume one or the other, requiring integrators to do extra work to
    wire propagators appropriately.
    
    Modifying the API of the propagators to consume the context as a mutable
    argument. By passing in the context rather than returning, this enables the
    chained use of propagators, allowing for situations such as supporting
    multiple trace propagation standards simulatenously.
    toumorokoshi committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    a8dc9b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Addressing feedback

    Migrating formatters outside of context. The design goal is to
    allow context to be it's own object agnostic of the requirements
    of specific telemetry. Instead, moving it under a broader propagators
    module.
    
    Removing UnifiedContext in lieu of directly using Context.
    UnifiedContext adds an unneeded layer of abstraction that would
    then require more operations to migrate into context.
    
    Removing binaryformat and httptextformat modules specific to
    SpanContext and DistributedContext. These are now handled by
    a single formatter.
    toumorokoshi committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    aab575f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f57b6 View commit details
    Browse the repository at this point in the history
  3. Removing mention of UnifiedContext

    Removing the last few mentions of UnifiedContext
    
    Fixing rst syntax of the context module.
    toumorokoshi committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    1f37b2a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Fixing sphinx warnings

    toumorokoshi committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    dc063a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c031df3 View commit details
    Browse the repository at this point in the history
  3. reverting type changes on class attributes

    Python3.4 and 3.5 do not support types on class attributes.
    toumorokoshi committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    3d8dbde View commit details
    Browse the repository at this point in the history
  4. Authoring a propagator class

    A Propagator class can help streamline integrations that require
    extracting and injecting context.
    toumorokoshi committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    4e55a5e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Fixing some errors

    Making the requests test pass again.
    
    Fixing propagator impl in the SDK. The correct fields were not being
    used.
    toumorokoshi committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    b755b0c View commit details
    Browse the repository at this point in the history
  2. Moving imports to relative

    In version of python before 3.7, a full import path involving a submodule
    was failing tests.
    toumorokoshi committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    e4d43cb View commit details
    Browse the repository at this point in the history