-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagator Class [POC for review] #121
Closed
toumorokoshi
wants to merge
10
commits into
open-telemetry:master
from
toumorokoshi:feature/propagators-object
Closed
Propagator Class [POC for review] #121
toumorokoshi
wants to merge
10
commits into
open-telemetry:master
from
toumorokoshi:feature/propagators-object
Commits on Sep 2, 2019
-
Adding a UnifiedContext, composing DistributedContext and SpanContext. This will enable propagators to extract and inject values from either system, enabling more sophisticated schemes and standards to propagate data. This also removes the need for generics and propagators that only consume one or the other, requiring integrators to do extra work to wire propagators appropriately. Modifying the API of the propagators to consume the context as a mutable argument. By passing in the context rather than returning, this enables the chained use of propagators, allowing for situations such as supporting multiple trace propagation standards simulatenously.
Configuration menu - View commit details
-
Copy full SHA for a8dc9b3 - Browse repository at this point
Copy the full SHA a8dc9b3View commit details
Commits on Sep 3, 2019
-
Migrating formatters outside of context. The design goal is to allow context to be it's own object agnostic of the requirements of specific telemetry. Instead, moving it under a broader propagators module. Removing UnifiedContext in lieu of directly using Context. UnifiedContext adds an unneeded layer of abstraction that would then require more operations to migrate into context. Removing binaryformat and httptextformat modules specific to SpanContext and DistributedContext. These are now handled by a single formatter.
Configuration menu - View commit details
-
Copy full SHA for aab575f - Browse repository at this point
Copy the full SHA aab575fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f57b6 - Browse repository at this point
Copy the full SHA 37f57b6View commit details -
Removing mention of UnifiedContext
Removing the last few mentions of UnifiedContext Fixing rst syntax of the context module.
Configuration menu - View commit details
-
Copy full SHA for 1f37b2a - Browse repository at this point
Copy the full SHA 1f37b2aView commit details
Commits on Sep 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dc063a2 - Browse repository at this point
Copy the full SHA dc063a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c031df3 - Browse repository at this point
Copy the full SHA c031df3View commit details -
reverting type changes on class attributes
Python3.4 and 3.5 do not support types on class attributes.
Configuration menu - View commit details
-
Copy full SHA for 3d8dbde - Browse repository at this point
Copy the full SHA 3d8dbdeView commit details -
A Propagator class can help streamline integrations that require extracting and injecting context.
Configuration menu - View commit details
-
Copy full SHA for 4e55a5e - Browse repository at this point
Copy the full SHA 4e55a5eView commit details
Commits on Sep 6, 2019
-
Making the requests test pass again. Fixing propagator impl in the SDK. The correct fields were not being used.
Configuration menu - View commit details
-
Copy full SHA for b755b0c - Browse repository at this point
Copy the full SHA b755b0cView commit details -
In version of python before 3.7, a full import path involving a submodule was failing tests.
Configuration menu - View commit details
-
Copy full SHA for e4d43cb - Browse repository at this point
Copy the full SHA e4d43cbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.