Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in context instead of parentcontext into samplers #1267

Merged
merged 7 commits into from Oct 26, 2020
Merged

Pass in context instead of parentcontext into samplers #1267

merged 7 commits into from Oct 26, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Oct 21, 2020

Fixes #1262

@lzchen lzchen requested a review from a team as a code owner October 21, 2020 21:14
@lzchen lzchen requested review from codeboten and toumorokoshi and removed request for a team October 21, 2020 21:14
@lzchen lzchen added the release:required-for-ga To be resolved before GA release label Oct 22, 2020
codeboten
codeboten approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just one non-blocking question.

opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py Show resolved Hide resolved
@codeboten codeboten merged commit d5e51a4 into open-telemetry:master Oct 26, 2020
@lzchen lzchen deleted the tracestate branch October 27, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@aabmass aabmass aabmass approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

Assignees

@codeboten codeboten

@aabmass aabmass

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampler.ShouldSample parent parameter to be Context
3 participants
@lzchen @codeboten @aabmass