Update protobuf versions #1356
Merged
Update protobuf versions #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
requested review from
codeboten and
lzchen
and removed request for
a team
aabmass
approved these changes
Nov 4, 2020
| @@ -41,7 +41,7 @@ packages=find_namespace: | |||
| zip_safe = False | |||
| include_package_data = True | |||
| install_requires = | |||
| protobuf~=3.12.2 | |||
There was a problem hiding this comment.
Might the ~= be better throughout?
lzchen
approved these changes
Nov 5, 2020
|
@NathanielRN |
codeboten
added
the
instrumentation
codeboten
approved these changes
Nov 5, 2020
|
@codeboten This is a pretty small change, but I was hoping we'd still be frozen on merging Contrib touching PRs until we get the rest of the PRs I have pending merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1355
Description
Updates the version of
protobufto the latest one.Fixes # (issue)
Type of change
How Has This Been Tested?
All regular tests are passing.
Checklist: