Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align optional parameters for span related to exceptions, add exception.escaped for record_exception #1365

Merged
merged 12 commits into from Nov 13, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Nov 9, 2020

start_as_current_span() and start_span() should have identical constructors. For the parameters related to exception and status:

  1. record_exception - whether or not to automatically call record_exception() if exception raised
  2. set_status_on_exception - whether or not to automatically set span status to ERROR if exception raised

As well, from this comment,
adding exception.escaped attribute when exception raised from span being used as a context manager.

@lzchen lzchen requested a review from a team as a code owner November 9, 2020 17:49
@lzchen lzchen requested review from owais and hectorhdzg and removed request for a team November 9, 2020 17:49
Comment on lines +862 to +863
if span._record_exception:
span.record_exception(exc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work if on line 854 if you did

with span:
    yield span

to avoid repeating this code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would work. The only reason why I left it in two different places is because record_exception wouldn't know if escaped is True or not.

@lzchen lzchen added the release:required-for-ga To be resolved before GA release label Nov 12, 2020
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

opentelemetry-sdk/tests/trace/test_trace.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants