Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when multiple instruments are registered by the same name #1438

Merged
merged 22 commits into from
Dec 7, 2020
Merged

Throw an error when multiple instruments are registered by the same name #1438

merged 22 commits into from
Dec 7, 2020

Conversation

srikanthccv
Copy link
Member

Description

Fixes #1201

@srikanthccv srikanthccv requested a review from a team as a code owner December 1, 2020 14:10
@srikanthccv srikanthccv requested review from codeboten and aabmass and removed request for a team December 1, 2020 14:10
aabmass
aabmass approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR!

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved
@srikanthccv srikanthccv mentioned this pull request Dec 3, 2020
Merged
@lzchen lzchen merged commit 8d195e6 into open-telemetry:master Dec 7, 2020
@lzchen lzchen mentioned this pull request Dec 8, 2020
Merged
8 tasks
@srikanthccv srikanthccv deleted the ot-1201 branch September 24, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meter implementations MUST return an error when multiple instruments are registered by the same name
3 participants
@srikanthccv @aabmass @lzchen