Auto-instrumentation should exclude packages mentioned in OTEL_PYTHON_DISABLED_INSTRUMENTATIONS env variable #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging from opentelemetry/master
merging from upstream/master
merging from upstream master
merging from upstream master
The auto-instrumentation will check for exclusion list and will auto-instrument packages not in the exclusion list.
import rearrangements
ocelotl
requested changes
Dec 11, 2020
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
|
Sure @ocelotl I will work on these changes. |
ocelotl
reviewed
Dec 11, 2020
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
owais
reviewed
Dec 12, 2020
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v0.16b1...HEAD) | |||
|
|
|||
| ### Added | |||
| - Added feature `auto-instrumentation should have a way to disable specific instrumentations` | |||
There was a problem hiding this comment.
This doesn't need to be in quotes and instead of saying "added feature <issue title>", it'd be nicer to just explain what exactly was added. For example, this could be something like "Added ability to disable specific instrumentations when using the opentelemetry-instrument command"
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
|
Sure @owais will work on these today. |
|
@owais , Do we need to update the README.rst to update this new env var. something like this
|
Modified the README.rst to add this detail.
dmarar
commented
Dec 12, 2020
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Show resolved
Hide resolved
…try-python add changes related to reading the env variable OTEL_PYTHON_DISABLED_INSTRUMENTATIONS into _load_instrumentors method
lzchen
reviewed
Dec 15, 2020
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Show resolved
Hide resolved
lzchen
approved these changes
Dec 16, 2020
ocelotl
approved these changes
Dec 16, 2020
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
…n/auto_instrumentation/sitecustomize.py Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
#1240
Type of change
Code
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: