Add some repr()s to basic trace types. #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
requested review from
owais and
aabmass
and removed request for
a team
|
@Oberon00 if you can update the branch we can get this merged |
|
There seems to be a problem with pypy in CI: |
|
@Oberon00 yes, the problem came from the underlying github action. this was fixed today if you want to update the branch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve
__repr__of DefaultSpan and SpanContext.Type of change
How Has This Been Tested?
Only manually.
Does This PR Require a Contrib Repo Change?
Checklist:
[ ] Unit tests have been added[ ] Documentation has been updated