Move b3 propagator out of SDK #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
toumorokoshi and
lzchen
and removed request for
a team
lzchen
reviewed
Jan 8, 2021
| @@ -16,7 +16,7 @@ DISTDIR=dist | |||
| mkdir -p $DISTDIR | |||
| rm -rf $DISTDIR/* | |||
|
|
|||
| for d in opentelemetry-api/ opentelemetry-sdk/ opentelemetry-instrumentation/ opentelemetry-proto/ exporter/*/ instrumentation/*/ ; do | |||
| for d in opentelemetry-api/ opentelemetry-sdk/ opentelemetry-instrumentation/ opentelemetry-proto/ exporter/*/ instrumentation/*/ propagator/*/; do | |||
There was a problem hiding this comment.
Nit: Should we name it propagators plural?
There was a problem hiding this comment.
eh..... maybe? though exporter is singular....
There was a problem hiding this comment.
+1 to leaving it as is, for consistencies sake with the other directories.
lzchen
approved these changes
Jan 8, 2021
|
Should we do something similar for the jaeger propagator? |
Yes, according to the spec it should also be moved out. I'll create an issue for it |
toumorokoshi
approved these changes
Jan 11, 2021
| @@ -16,7 +16,7 @@ DISTDIR=dist | |||
| mkdir -p $DISTDIR | |||
| rm -rf $DISTDIR/* | |||
|
|
|||
| for d in opentelemetry-api/ opentelemetry-sdk/ opentelemetry-instrumentation/ opentelemetry-proto/ exporter/*/ instrumentation/*/ ; do | |||
| for d in opentelemetry-api/ opentelemetry-sdk/ opentelemetry-instrumentation/ opentelemetry-proto/ exporter/*/ instrumentation/*/ propagator/*/; do | |||
There was a problem hiding this comment.
+1 to leaving it as is, for consistencies sake with the other directories.
owais
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the b3 propagator into its own package
opentelemetry-propagator-b3as per the spec.Fixes #1221
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: