Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default port for OTLP exporter to 4317 #1516

Merged
merged 7 commits into from Jan 12, 2021
Merged

Update default port for OTLP exporter to 4317 #1516

merged 7 commits into from Jan 12, 2021

Conversation

srikanthccv
Copy link
Member

Description

Fixes #1515

@srikanthccv srikanthccv requested a review from a team as a code owner January 9, 2021 13:15
@srikanthccv srikanthccv requested review from codeboten and hectorhdzg and removed request for a team January 9, 2021 13:15
codeboten
codeboten approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion for the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@codeboten codeboten merged commit db74594 into open-telemetry:master Jan 12, 2021
@srikanthccv srikanthccv mentioned this pull request Feb 5, 2021
Closed
@srikanthccv srikanthccv deleted the otlp-port-fix branch September 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@codeboten codeboten codeboten approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default port for OTLP exporter to 4317
3 participants
@srikanthccv @owais @codeboten