Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InstrumentationInfo tag keys for Jaeger and Zipkin exporters #1535

Merged
merged 7 commits into from Jan 19, 2021

Conversation

srikanthccv
Copy link
Member

Description

From sdk exporters specs.

OpenTelemetry Span's InstrumentationLibrary MUST be reported as span tags to Jaeger/Zipkin using the following mapping.

OpenTelemetry Jaeger/Zipkin
InstrumentationLibrary.name otel.library.name
InstrumentationLibrary.version otel.library.version

@srikanthccv srikanthccv requested a review from a team as a code owner January 16, 2021 12:26
@srikanthccv srikanthccv requested review from aabmass and lzchen and removed request for a team January 16, 2021 12:26
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codeboten codeboten merged commit 98f7b60 into open-telemetry:master Jan 19, 2021
@srikanthccv srikanthccv deleted the instrumentation-lib-key branch September 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants